Issue #259 - Embed images in CSS so asset fingerprinting works.

[pbougie]

Moves images into base64-encoded CSS to fix problems when using the Rails asset pipeline and asset fingerprinting. Changing an image is almost as easy as it was: instead of changing the image in the filesystem, you simply base64 encode it and paste it into the CSS. Use an encoder such as this one: http://webcodertools.com/imagetobase64converter

[OscarGodson]

@gankro what do you think about this?

[Gankra]

Base64 embedding in CSS:

• more portable
• easy for users to clobber/replace
• less HTTP reqs
• well supported as far as I can tell
• better versionable?

Seems like a good call to me. My only issues are implementation specific.

[pbougie]

Since this is all in an iframe, its not clear to me that you need anything more than .epiceditor-fullscreen-foo as the selectors here.

I never touched any of the selectors. Any refactoring of selectors should probably be done elsewhere.

Semantically, should these not be ?

Agreed. I made the changes.

Not a huge fan of useless whitespace edits, but that's just me.

I mistakenly let those go through. I've reverted the whitespace edits. However, trailing whitespace should be removed project-wide but should be done in another commit.

[OscarGodson]

@pbougie thanks. I'll take a look at this tonight or something. Did you check IE9-10?

[pbougie]

Works well in IE9-10. Is there somewhere where you list browser compatibility for EpicEditor?

On 2013-06-29, at 15:09 , Oscar Godson notifications@github.com wrote:

@pbougie thanks. I'll take a look at this tonight or something. Did you check IE9-10?

—
Reply to this email directly or view it on GitHub.

[OscarGodson]

Thanks @gankro! The code all looks good to me too. I'm going to test it locally real quick then merge it if it looks good.

[OscarGodson]

IE9:

[OscarGodson]

Buttons are still buttons and base64 doesnt seem to be working.

[pbougie]

@OscarGodson Works fine here. Looks like the new styles are missing. Did you force reload the CSS?

[OscarGodson]

I can try again later. Works fine in IE10 mode tho which means the caching shouldn't be a problem.

[OscarGodson]

@pbougie Deleted everything (cookies, cache, etc) and finally it worked. Hopefully this isn't an issue when upgrading for people.

Thanks again for the contribution :)