added the ability to wrap a textarea #232
Conversation
…as the sync textarea
|
So, to be clear, if you had: <div id="epiceditor">
<textarea></textarea>
</div>It would use that textarea, automatically, to sync content? |
|
That's the idea |
|
Removed check and IE10 tested |
|
Rad! I'll check play with this when I get home tonight then. Thanks, man! |
|
Pulled this down and it doesn't appear to work for me. <div id="epiceditor">
<textarea></textarea>
</div>
<script src="/epiceditor/js/epiceditor.js"></script>
<script>
var editor = new EpicEditor().load();
</script>The textarea appears to be removed. This line is doing it (99.9% sure) https://github.com/OscarGodson/EpicEditor/blob/develop/src/editor.js#L532 Actually, I'm not sure how this worked for you since |
|
The loading from the contained textarea definatly works for me, however what I hadn't tested or checked was that the textarea is placed back on the form after the editor is done. Think I might need to play with this a little before you consider pulling this. |
|
oh, I see. This was just for initial loading. Yeah, most people requested the textarea feature so that they could submit a form the old school way so the textarea has to be in the DOM when the form is submitted. |
|
What's your feelings on CSS added via JS? In this case, |
|
As long as the docs make it clear that by putting the textarea in the epiceditor container will hide the textarea and replace it with epiceditor. |
|
I believe this is complete. Fancy giving it a go? |
|
Will do, sorry for the delay. I've been reviewing PRs for the 0.2.1 release. I'm going to package and ship 0.2.1 first and then I'll take a look at this. I will try to package and ship it tonight and take a look at this tomorrow. Thanks again! |
|
Ah, I thought perhaps you weren't sure I'd finihed making changes. On Mon, Jun 10, 2013 at 7:00 PM, Oscar Godson notifications@github.com
|
|
OK, 0.2.1 was just released. I'll take a look at this ASAP (tonight/tomorrow) and test it in all the browsers. |
|
OK, checked and everything looks and works good. Few things:
If you don't have time or don't want to I can take care of these myself. |
|
P.S. sorry it took so long to get to this. Was busy with stuff :( |
|
bump? |
|
Yeah sorry, newborns can be a little distracting. I'll look into this weds/thurs as I'm back to work then On Tue, Jul 16, 2013 at 7:30 AM, Oscar Godson notifications@github.com
|
|
@bytespider totally understood. Thanks :) |
|
I just noticed you put some commits in. Is that everything you wanted to get in? |
|
I think so, unless you had some comments on the docs? On Mon, Jul 22, 2013 at 11:28 PM, Oscar Godson notifications@github.com
|
|
Rad, no, I just never got a comment from you. I don't get notified of commits, just comments :) I'll look at it during lunch |
|
Oh right, Thought it did as the commits were inline on GH On Tue, Jul 23, 2013 at 7:06 PM, Oscar Godson notifications@github.com
|
|
When I mentioned applyAttrs, I didn't mean that one style, I meant where you set that block of attrs on L540-L543. |
|
Clearly I miss understood you. Will sort. On Tue, Jul 23, 2013 at 11:07 PM, Oscar Godson notifications@github.com
|
|
|
|
Okay. So I used _applyAttrs, however it refuses to set frameborder. |
|
I will review this ASAP :) I wanna get this into the next release! |
Wrap a textarea with the container and use that as the sync textarea