Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

themes shouldn't have to be inside the epiceditor directory #196

Closed
themightychris opened this issue Jan 4, 2013 · 2 comments
Closed

themes shouldn't have to be inside the epiceditor directory #196

themightychris opened this issue Jan 4, 2013 · 2 comments
Labels
0.2.1 Easy Feature QA'd
Milestone
1.0

Comments

@themightychris
Copy link

I want to avoid modifying modifying the epiceditor source tree when linking in new preview themes. Please update the config option handling so that theme CSS paths matching /^https?:///i don't get prefixed with basePath and then users can link to external CSS files
@OscarGodson
Copy link
Owner

Kinda "magical" since basePath implies it's the base path to everything, but I think it makes sense because you'd never have http://foo.com/my/themes/http://...

OscarGodson added a commit that referenced this issue Jan 12, 2013
@OscarGodson
Ticket #196 - preview() will now load a theme with an absolute link w…
7301ca3 
…ithout the

basePath. Need to add this in the other places we load stylesheets still and
add tests.
OscarGodson added a commit that referenced this issue Jan 13, 2013
@OscarGodson
Ticket #196 - check if any of the theme paths have absolute links and…
2d9601a 
… if NOT add the

basePath, if YES, then leave them as is.
OscarGodson added a commit that referenced this issue Jan 13, 2013
@OscarGodson
Ticket #196 - Added tests
9efdfe7
@OscarGodson
Copy link
Owner

This has landed in develop with tests. Thanks!

OscarGodson added a commit that referenced this issue Jan 15, 2013
@OscarGodson
Ticket #196 - Fixed linting error in test
a826e08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.2.1 Easy Feature QA'd
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@OscarGodson @themightychris