feat(debug): add debug logs for diagnosing issues #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenlautier
commented
Jun 6, 2019
| [*] | ||
| indent_size = 4 | ||
| indent_style = space | ||
|
|
||
| [*.{json,yml,csproj,md}] |
There was a problem hiding this comment.
this was ordered as it wasnt working
galvesribeiro
added a commit
that referenced
this pull request
Jun 6, 2019
* Refactoring and fixes (#71) * add todos * todo * - ClientGrain - remove hubname + connectionId OnConnect - remove this. (for build) * ad todo test * connectionGrainKey + ConnectionGrain change hub from key * rename to Send and align - type InvocationMessage - SendExcept moved to ConnectionGrain - Add HubMessageInvoker so extention is available on all grains (including Client) * remove redundant casting + use connection.UserIdentifier * remove todo * add test + fix when sending to client and within groups fails to send to rest * remove whitespace from log * remove redundant token + type AllMessage + remove test * remove redundant token * feat(debug): add debug logs for diagnosing issues (#74) * feat(debug): add debug logs for diagnosing issues * add further logs * feat(hub): hub naming now is invariant and will always use interface naming (#77) * feat(hub): hub naming now it is invariant and it will always use the interface naming instead consistently * fix non generic + add further tests * feat(version): bump versions (#76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some useful debug logs when diagnosing issues.
Reason: Currently, we are having an issue that we are sending a message to a group and the connection is receiving the message multiple times on the client; however in our logs, we are sending it once, so a log like this would be super useful in this case to further diagnose this problem.
Features
Docs