feat(all): upgrade to Olreans RC1
#25
Conversation
src/SignalR.Orleans/Extensions.cs
Outdated
|
|
||
| return builder.AddMemoryGrainStorage(Constants.STORAGE_PROVIDER) | ||
| .AddSimpleMessageStreamProvider(Constants.STREAM_PROVIDER) | ||
| .ConfigureApplicationParts(parts => parts.AddFromAppDomain().AddFromApplicationBaseDirectory()); |
There was a problem hiding this comment.
Please revert this line to the previous one. Load from appdomain/base directory impose a restriction.
Load the current assembly is the correct way if doing it.
There was a problem hiding this comment.
is it ok if i will do it like this:
.ConfigureApplicationParts(parts => parts.AddApplicationPart(Assembly.GetExecutingAssembly()).WithReferences())
instead of specifing an actual class:
.ConfigureApplicationParts(parts => parts.AddApplicationPart(typeof(IClientGrain).Assembly).WithReferences())
There was a problem hiding this comment.
Executing assembly is where the Main() entrypoint is. The way it is, we ensure the assembly is loaded properly to avoid problems of assembly loading/binding at runtime in Orleans.
src/SignalR.Orleans/Extensions.cs
Outdated
| builder.Services.AddSingleton(typeof(HubLifetimeManager<>), typeof(OrleansHubLifetimeManager<>)); | ||
| return builder; | ||
| return builder.AddSimpleMessageStreamProvider(Constants.STREAM_PROVIDER) | ||
| .ConfigureApplicationParts(parts => parts.AddFromAppDomain().AddFromApplicationBaseDirectory()) |
No description provided.