Skip to content
This repository was archived by the owner on May 24, 2024. It is now read-only.

Add CodePen examples #40

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Add CodePen examples #40

merged 1 commit into from
Jun 28, 2018

Conversation

micahalcorn
Copy link
Member

This resolves #11 by adding three examples with code playgrounds:

  1. Get listing
  2. Get listing by index
  3. Create listing

This is a minimal proof-of-concept, which only handles the failure case of not having a web3-enabled browser. I will create additional GitHub issues for other enhancements.

@wanderingstan
Copy link
Contributor

wanderingstan commented Jun 28, 2018

Noticed that the examples fail silently if you're not on Rinkeby. I suggest we move that test, and the test for web3 in general, to a standard js file that's included with codepen.

But it still looks great as is. I'll just make an issue for the Rinkeby thing and merge+deploy this PR.

@wanderingstan
Copy link
Contributor

wanderingstan commented Jun 28, 2018

Also, looks like we can style our pens to match the colors of our docs site:
https://blog.codepen.io/documentation/features/embedded-pens/#embed-themes-1

@micahalcorn can you pm me the OriginProtocol login creds?

EDIT: Looks like its pretty limited what we can do, but we can still at least match the header to our colors.

@wanderingstan wanderingstan merged commit 7ce61d4 into master Jun 28, 2018
@micahalcorn micahalcorn deleted the codepen branch June 28, 2018 22:07
@micahalcorn micahalcorn mentioned this pull request Jun 30, 2018
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code examples to our docs using jsfiddle.com or something similar
2 participants