Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#99 - Allow any entity scoring (Breaking changes) #132

Merged
merged 11 commits into from
Dec 14, 2022
Merged

#99 - Allow any entity scoring (Breaking changes) #132

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
90e7435
Add entityRef to enable all entity scoring (wip)
T0RAT0RA Dec 8, 2022
abda953
Add new config `useEntityRef` to use entity reference in scorecard URL
T0RAT0RA Dec 9, 2022
bd89a5c
Simplify the code by removing backward compatibility
T0RAT0RA Dec 13, 2022
c5cad19
Remove unused keys from all.json
T0RAT0RA Dec 13, 2022
9705d87
Remove scorecard from overview page
T0RAT0RA Dec 13, 2022
e1060a3
Fix path in tests
T0RAT0RA Dec 13, 2022
f41adc5
Add MemoryRouter to fix test
T0RAT0RA Dec 13, 2022
d5d8100
Add new column Kind
T0RAT0RA Dec 13, 2022
fa1d24c
Replace "systems" by "entities" in documentation
T0RAT0RA Dec 14, 2022
16390ec
Add changeset
T0RAT0RA Dec 14, 2022
01f7124
Update .changeset/poor-pillows-roll.md
T0RAT0RA Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/app/src/components/catalog/EntityPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,13 @@ const apiPage = (
</Grid>
</Grid>
</EntityLayout.Route>
<EntityLayout.Route path="/score" title="Score">
<Grid container spacing={3} alignItems="stretch">
<Grid item xs={12}>
<EntityScoreCardContent />
</Grid>
</Grid>
</EntityLayout.Route>
</EntityLayout>
);

Expand Down
65 changes: 54 additions & 11 deletions plugins/score-card/sample-data/all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,61 @@
[
{
"systemEntityName": "non-valid-system",
"systemTier": "B",
"SystemDataConfidentiality": "Public",
"entityRef": {
"kind": "api",
"name": "api.foo"
},
"scorePercent": 50,
"scoreLabel": "Yellow",
"scoringReviewDate": "2022-01-01T08:00:00Z",
jvilimek marked this conversation as resolved.
Show resolved Hide resolved
"scoreSuccess": "almost-failure",
"areaScores": [
{
"title": "Extensibility",
"scorePercent": 50,
"scoreLabel": "Yellow",
"scoreSuccess": "almost-failure"
},
{
"title": "Code",
"scorePercent": 100,
"scoreLabel": "Green",
"scoreSuccess": "success"
},
{
"title": "Quality",
"scorePercent": 25,
"scoreLabel": "Red",
"scoreSuccess": "failure"
},
{
"title": "Documentation",
"scorePercent": 100,
"scoreLabel": "Green",
"scoreSuccess": "success"
},
{
"title": "Operations",
"scorePercent": 50,
"scoreLabel": "Yellow",
"scoreSuccess": "almost-failure"
}
]
},
{
"entityRef": {
"kind": "system",
"name": "non-valid-system"
},
"generatedDateTimeUtc": "2021-07-22 10:00",
"scorePercent": 20,
"scoreSuccess": "failure",
"scoringReviewer": "n/a"
},
{
"systemEntityName": "audio-playback",
"systemTier": "A",
"SystemDataConfidentiality": "Confidential",
"SystemDataSensitivity": ["PII", "Sensitive-PII"],
"entityRef": {
"kind": "system",
"name": "audio-playback"
},
"generatedDateTimeUtc": "2021-07-22 10:00",
"scorePercent": 57,
"scoringReviewer": "Guest",
Expand Down Expand Up @@ -317,10 +360,10 @@
]
},
{
"systemEntityName": "podcast",
"systemTier": "A",
"SystemDataConfidentiality": "Confidential",
"SystemDataSensitivity": ["PII", "Sensitive-PII"],
"entityRef": {
"kind": "system",
"name": "podcast"
},
"generatedDateTimeUtc": "2021-07-22 10:00",
"scorePercent": 57,
"scoreLabel": "C",
Expand Down
Loading