Settings/validate input #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| value: currentNewColor, | ||
| placeholder: `Default: ${defaultColor}`, | ||
| value: colorValue, | ||
| type: 'text', |
Collaborator
There was a problem hiding this comment.
I'll just leave this here: https://devdocs.io/html/element/input/color
| const exampleProps = { | ||
| style: { | ||
| display: 'inline-block', | ||
| backgroundColor: colorToBeUsed, |
Collaborator
There was a problem hiding this comment.
Use CSS for all non dynamic values and inline style for only dynamic ones.
| } | ||
| componentWillUpdate(nextProps, nextState) { | ||
| const { stateValidation, newColorNames, } = this; | ||
| const isHexColor = colorKey => ( |
Collaborator
There was a problem hiding this comment.
Apart from https://devdocs.io/html/element/input/color , you should use input[pattern] https://devdocs.io/html/attributes#pattern-attribute and use the validity property CSS https://devdocs.io/css/:valid and API https://devdocs.io/dom/validitystate
All of these are documented well here: https://developer.mozilla.org/en-US/docs/Learn/HTML/Forms/Form_validation
OriLev
added a commit
that referenced
this pull request
Apr 12, 2018
* fix Nick's comments to PR#7 * fix a function name according to Nick's comments to PR#7 * fix Nick's comments to PR#7 and PR#8 * remove dist/ from git repository * add page header to settings page * add color inputs and submit button for settings page * fix missing key in NewColorsInput * change lint rule regarding the label tag and refactor code accordingly * update key value from index to colorLetter * fix indentation * refactor the setState syntax * change text shown * Settings/validate input (#11) * add validation on input entry * add validation for new color inputs * clean SettingPanel variables * add feedback and design and design the settings panel * change the color input type from text to color * add reset button * prepare for github pages deployement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the app now validates the new color inputs and uses default values if the input is NOT valid.