Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add comment button on pr page #9

Merged
merged 3 commits into from
May 23, 2023
Merged

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented May 19, 2023

closes #7

  1. Add a new function EnsureCommentButtonOnPR that adds a comment button on PR page.
image image
  1. Update Init() to include a MutationObserver for EnsureCommentButtonOnPR function.

  2. Change @run-at to document-end: The script will be injected when or after the DOMContentLoaded event was dispatched. (Documentation)

    • If using document-start, both EnsureCommentButtonOnPR and EnsureCommentButton fails at the beginning.
    image

@ran-huang
Copy link
Contributor Author

@Oreoxmt PTAL~

…targetnode

Signed-off-by: Ran <huangran.alex@gmail.com>
gh-util.user.js Show resolved Hide resolved
gh-util.user.js Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review May 22, 2023 13:09
Co-authored-by: Aolin <aolinz@outlook.com>
@Oreoxmt Oreoxmt merged commit e303659 into Oreoxmt:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: add a button/toggle on PR page to help quickly approve and merge
2 participants