-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pull Request Github workflow #96
Conversation
Failing because of net6.0 |
We would need to multi-target like we do in OC. @bleroy does that make sense or you want to only keep one framework? |
It makes sense, but if that's too much work, latest supported by OC wouldn't be terrible |
I could add a common .csproj as we do in OC to add vars for these that we could reuse in each project. Not too much work, I just copy some stuff I already have and adapt it. |
I will make a different PR for multi-targeting. That's mainly why I had copied the main OC repository structure. To be able to copy/paste these files without having to adapt them for both projects. |
Finally building and passing unit tests! The issue was that when we are specifying a unique framework in the projects then we should not pass the --framework argument on the command line when doing dotnet build. In the future though, when we move to multi-targeting it will make sense to pass the --framework argument. So here the CI works with what we have before moving to .NET 6.0. |
Ok I'm done adding commits if you want to merge @bleroy |
Thanks for sorting this out! |
Fixes #95, Fixes #80
See :