Currency selector #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microposmp
force-pushed
the
currency-display-strategy
branch
from
75d33f6 to
199de95
Compare
bleroy
requested changes
Feb 16, 2020
microposmp
force-pushed
the
currency-display-strategy
branch
from
199de95 to
dda3297
Compare
|
I agree that the currency selector should be in it's own feature in the future. The current settings based implementation I think can be removed altogether when a more real world implementation is in place. I think it's good to have right now during early development when concepts are being tried out. |
microposmp
force-pushed
the
currency-display-strategy
branch
from
dda3297 to
0bbb926
Compare
|
This is currently broken. Please wait with further review. |
microposmp
force-pushed
the
currency-display-strategy
branch
from
2c65248 to
490c923
Compare
Basic infrastructure for supporting price display in different currencies.
microposmp
force-pushed
the
currency-display-strategy
branch
from
490c923 to
db4ae29
Compare
bleroy
reviewed
Feb 28, 2020
Startup.cs
Outdated
| @@ -107,4 +105,14 @@ public override void Configure(IApplicationBuilder app, IEndpointRouteBuilder ro | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Move to it's own project? Think about Commerce solution structure... | |||
There was a problem hiding this comment.
Removed comment.
bleroy
approved these changes
Feb 28, 2020
|
Is this good to merge now? LGTM. |
Currency selector intended for (Dev/Test) scenarios.
microposmp
force-pushed
the
currency-display-strategy
branch
from
42b8178 to
d1c8cd8
Compare
|
It's ok to merge. Thanks. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented logic to be able to select the currency prices are shown in on the site. It builds on the configuration settings that were added to the PricePart.
There are two implementations added:
Update in Startup.cs which implementation will be used.
Notes: