Remove Lombiq.NodeJs.Extensions

[Skrypt]

Feel free to comment.

Fixes #527
Fixes #535

[sarahelsaig]

Just removing the tool will break OCC, which is why tests are failing. As discussed in the issue, the JS files have to be moved (as indicated here, here and here). Also SCSS have to be ported to CSS (as indicated here and here)

[sarahelsaig]

If Lombiq.NodeJs.Extensions is removed, the package.json files won't be needed at all.

[Skrypt]

Thanks, I'll try doing that later this week.
I'm going to try also the multi-targetting of frameworks on a different PR.
I generally just copy the folder structure of OC and import the build files in my Nuget package solution. This was I spend less time changing that code on every releases.

[sarahelsaig]

Thanks, I'll try doing that later this week.
I'm going to try also the multi-targetting of frameworks on a different PR.

That sounds good, much appreciated! 😊

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[Skrypt]

I've cleaned up the solution so that I could get multi-targeting working. Right now, it works but with a lot of errors to fix before being able to compile but I think I figured out most of the configs for multi-targeting.

[Skrypt]

I did change the structure of the folders so that it matches OC repository so that it be easier for me to just copy/paste some of the files that are in that repository. Normally, what I do is that I keep the same folder structure so that it is easier to just copy/paste configs/tools from OC to my Nuget package solutions. This way I don't need to change paths in these files.

[sarahelsaig]

The GitHub Actions build fails with a bunch of errors like this:

Error: /usr/share/dotnet/sdk/8.0.301/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(166,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 9.0. Either target .NET 8.0 or lower, or use a version of the .NET SDK that supports .NET 9.0. Download the .NET SDK from https://aka.ms/dotnet/download [/home/runner/work/OrchardCore.Commerce/OrchardCore.Commerce/src/OrchardCore.Modules/OrchardCore.Commerce.Tax/OrchardCore.Commerce.Tax.csproj::TargetFramework=net9.0]

[Skrypt]

Yeah don't look too much at errors it's a WIP. Just letting you know to see if you agree with the folder structure change.

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[sarahelsaig]

I assume this whole App_Data directory was committed by accident?

You've changed the OrchardCore.Commerce.Web to OrchardCore.Cms.Web (why?) but then didn't update the .gitignore file, which is probably the reason.

[sarahelsaig]

Yeah don't look too much at errors it's a WIP. Just letting you know to see if you agree with the folder structure change.

I see, thanks for the clarification. I am swamped now but I can look it over more on Monday.

@Piedone , do you have opinions about the folder structure change here? (or about nowarn stuff added to Directory.Build.props)