-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PricePart currency configuration. #51
PricePart currency configuration. #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few suggestions, but in general, if the feature isn't feature complete, I would rather have it live on its own branch until it is, if that's ok with you. Thanks for the contribution, this should be very useful.
Thanks for the review. It's ok to keep it in this branch until it's complete. Just wanted some feedback on the idea of how to handle this. This replaces the old idea to configure what currencies should be available to select on the site. |
Yes, I like it better as a setting on the part. Maybe later there can be an additional mode with multi-selection. |
f043084
to
d62247f
Compare
Now all review points should be ok. I've thought about multi-selection mode. For that I think we should have a different display in the admin. For example if 3 currencies are selected it should draw 3 entry fields so it will be consistent which currency amount is entered in each separate entry field. |
2833ed0
to
5f45c97
Compare
d35f72c
to
58e8306
Compare
58e8306
to
31186c9
Compare
Thanks for great feedback during the review. I plan to look at multiple selection mode later. Probably after a pricing strategy is in place that will support selecting the correct currency. It can be achieved today by adding multiple PriceParts to a product type with different currencies. For multiple selection mode I think about 2 scenarios:
|
I'm partial to columns of checkboxes for this type of multiple choice. |
Thanks for the contribution! |
Added a settings option on PricePart that makes it possible to configure/restrict what currencies are possible to select when entering data for a product. This way rules can be setup when the product type is designed and make the entered data more reliable.
Possible options:
On a product type multiple PricePart objects can be attached with different configurations.
Some examples:
A site that only sells in one market/region can add a single PricePart to the product type and configure it to use the default currency.
A site that targets multiple markets/regions can add more than one PricePart when designing the product type. One PricePart with the default currency and additional PricePart objects configured for a specific currency. For this to work some kind of pricing strategy will need to be configured that selects the price in the correct currency.