-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopping cart #39
Merged
Merged
Shopping cart #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attributes to shopping cart items.
…and do some cleanup
# Conflicts: # Models/ShoppingCartItem.cs # OrchardCore.Commerce.csproj
…nc; only have product SKU instead of product content item on the shopping cart item
…o-script situations, modify shopping cart controller to use parsable view models.
# Conflicts: # Permissions.cs
…heir names, values, settings.
Remove the price abstraction, add price selection strategy for future use, modify cart controller to redirect to index from all other actions, and to add prices to new cart items, begin custom cart item serialization, fix product retrieval from database, finish attribute model binding
… instead of Newtonsoft where possible
Closed
Skrypt
reviewed
Oct 28, 2019
agriffard
reviewed
Oct 29, 2019
Yes, that's my last minute addition of a placement file. I'll fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete implementation of an attribute-aware shopping cart.
Note that this is almost entirely devoid of javascript, by design. Later on, we'll have incremental cart improvements, such as a shopping-cart widget that can be on all pages and that supports Ajax updates, as well as alternative cart storage, including client storage.