Fix uninitialized currency providers and settings #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The clarity added in naming is fantastic and makes perfect sense. I am going to try and pull it local and run it on a fresh instance to test. With these changes, do you even still need the "CommerceSettingsConfiguration.cs" file? I don't think a "Default Currency" can ever be null or empty with the changes you have made... If it is still needed, it should be cleaned up as it still uses "Symbol" instead of "IsoCode" for setting the "DefaultCurrency". |
|
I have tested on a fresh install and works as expected. If you can comment on the "CommerceSettingsConfiguration.cs" file (whether it needs kept or modified) then I would be ready to merge this (or you can of course). |
bleroy
force-pushed
the
fix-default-currency-master
branch
from
ef49131 to
4d0184e
Compare
|
Removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also disambiguates usage of ISO symbol/code, and adds a bunch of tests for the money service.
Fixes #35