-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PricePart default currency #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, first PR, thanks! Please delete the commented out code and I'll just merge this, looks good!
public class CommerceSettingsConfiguration : IConfigureOptions<CommerceSettings> | ||
{ | ||
private readonly ISiteService _site; | ||
//private readonly IDataProtectionProvider _dataProtectionProvider; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete, rather than comment out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed commented out code and squashed the commit into the previous commit.
If you could also squash out those gitignore changes, to keep history clean, that would be great. Thanks! |
Great thanks. Unless you're going to do it yourself, I'll squash some of those before I merge. |
Hi, I don't know how to do the squash. I'll learn that for future commits. Can you do it for this change? Thanks |
Sure, no problem. I'll do it, that's perfectly fine. FWIW, the way you do it is that you do an interactive rebase, something like |
…t attached. This issue is solved by assigning the default currency when creating a new object.
Changed to display IsoCode in PricePart editor. Many currencies have the same symbol, so it's not clear what currency is selected.
I've implemented a few small changes for the PricePart.
I'm interested in participating in the development of the OrchardCore.Commerce module.