Add content warnings for videos/links #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-kelp
commented
Jun 6, 2024
| "has_content_warning", | ||
| sa.Boolean(), | ||
| nullable=False, | ||
| server_default="false", |
There was a problem hiding this comment.
This migration does not add content warnings to existing links and videos, so users will need to mark those manually
3 tasks
michplunkett
added a commit
to lucyparsons/OpenOversight
that referenced
this pull request
Jun 18, 2024
## Fixes issue Fixes #493 ## Description of Changes *This change is cherry-picked from OrcaCollective#457 Adds content warnings to links and videos ## Notes for Deployment There's an alembic migration that will need to be run ## Screenshots (if appropriate) New checkbox "Include content warning?" which is checked by default per #493 (comment)  How links and videos will look when a content warning is added:  ## Tests and Linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment. --------- Co-authored-by: michplunkett <5885605+michplunkett@users.noreply.github.com>
AetherUnbound
approved these changes
Jun 22, 2024
| const hide = $('<button type="button" class="btn btn-lg">Show video</button>') | ||
| hide.click(() => overlay.css("display", "none")) | ||
|
|
||
| const wrapper = $("<div>") |
There was a problem hiding this comment.
Do we need to add a </div> to this or does jquery handle it for us?
There was a problem hiding this comment.
Edit: This is the case based on the Jquery documentation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #197.
Adds content warnings to links and videos!
Notes for Deployment
There's an alembic migration that will need to be run
Screenshots (if appropriate)
New checkbox "Include content warning?" which is checked by default per lucyparsons#493 (comment)
How links and videos will look when a content warning is added:
Tests and linting
I have rebased my changes on
mainjust lintpassesjust testpasses