Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload bugs #434

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Fix upload bugs #434

merged 3 commits into from
Apr 10, 2024

Conversation

sea-kelp
Copy link
Collaborator

@sea-kelp sea-kelp commented Apr 7, 2024

Description of Changes

  • Fixed bug introduced in Pluralize REST routes lucyparsons/OpenOversight#1018 where anonymous uploads were silently failing due to misplaced @login_required decorator
  • Audited all other redirect routes
  • Fixed note_detail.html and description_detail.html
  • Fixed note deletion

Notes for Deployment

None!

Screenshots (if appropriate)

N/A

Tests and linting

  • I have rebased my changes on main

  • just lint passes

  • just test passes

@sea-kelp sea-kelp requested a review from a team as a code owner April 7, 2024 20:04
michplunkett pushed a commit to lucyparsons/OpenOversight that referenced this pull request Apr 8, 2024
## Description of Changes
*Cherry-pick of
OrcaCollective#434

* Fixed bug introduced in
#1018 where anonymous
uploads were silently failing due to misplaced `@login_required`
decorator
* Audited all other redirect routes
* Fixed note_detail.html and description_detail.html

## Notes for Deployment
None!

## Screenshots (if appropriate)
N/A

## Tests and Linting
 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes here look good! I'm getting "invalid data type" errors when I try to upload certain jpgs locally 😕 that looks unrelated though, so I won't let it block this PR.

@AetherUnbound AetherUnbound merged commit c95f151 into main Apr 10, 2024
2 checks passed
@AetherUnbound AetherUnbound deleted the fix/upload-bug branch April 10, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants