Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NodeSource deprecation warning #362

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

sea-kelp
Copy link
Collaborator

@sea-kelp sea-kelp commented Sep 25, 2023

Description of Changes

Fixes #359. Replaces NodeSource installation script with repository.

NodeSource added a 60 second delay to its installation script along with a deprecation warning banner. This change migrates to their new repository according to these instructions: https://github.com/nodesource/distributions#supported-versions

#9 3.472 ================================================================================
#9 3.472 ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓
#9 3.472 ================================================================================
#9 3.472 
#9 3.472                            SCRIPT DEPRECATION WARNING                    
#9 3.472 
#9 3.472   
#9 3.472   This script, located at https://deb.nodesource.com/setup_X, used to
#9 3.472   install Node.js is deprecated now and will eventually be made inactive.
#9 3.472 
#9 3.472   Please visit the NodeSource distributions Github and follow the
#9 3.472   instructions to migrate your repo.
#9 3.472   https://github.com/nodesource/distributions
#9 3.472 
#9 3.472   The NodeSource Node.js Linux distributions GitHub repository contains
#9 3.472   information about which versions of Node.js and which Linux distributions
#9 3.472   are supported and how to install it.
#9 3.472   https://github.com/nodesource/distributions
#9 3.472 
#9 3.472 
#9 3.472                           SCRIPT DEPRECATION WARNING
#9 3.472 
#9 3.472 ================================================================================
#9 3.472 ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓
#9 3.473 ================================================================================
#9 3.473 
#9 3.473 TO AVOID THIS WAIT MIGRATE THE SCRIPT
#9 3.473 Continuing in 60 seconds (press Ctrl-C to abort) ...

Notes for Deployment

None!

Screenshots (if appropriate)

N/A

Tests and linting

  • I have rebased my changes on main

  • just lint passes

  • just test passes

@sea-kelp sea-kelp mentioned this pull request Oct 4, 2023
@sea-kelp sea-kelp marked this pull request as ready for review October 9, 2023 07:48
@sea-kelp sea-kelp requested a review from a team as a code owner October 9, 2023 07:48
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Deprecation warning is no longer present when I build the image 🥳

@AetherUnbound AetherUnbound merged commit 869dc22 into main Nov 26, 2023
2 checks passed
@AetherUnbound AetherUnbound deleted the 359/fix-node-source branch November 26, 2023 23:47
@sea-kelp sea-kelp linked an issue Dec 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade Node from v16 Fix node-source deprecation warning
2 participants