Upgrade SQLAlchemy #315
Merged
Upgrade SQLAlchemy #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-kelp
commented
May 14, 2023
Comment on lines
+125
to
+127
| Face.query.join(Officer, Face.officer_id == Officer.id) | ||
| .join(Department, Officer.department_id == Department.id) | ||
| .filter(Department.id != AC_DEPT) |
There was a problem hiding this comment.
Comment on lines
+111
to
118
| def test_filters_do_not_exclude_officers_without_assignments(mockdata, db): | ||
| department = OpenOversight.app.models.Department.query.first() | ||
| officer = OpenOversight.app.models.Officer( | ||
| first_name="Rachel", last_name="S", department=department, birth_year=1992 | ||
| ) | ||
| db.session.add(officer) | ||
| results = OpenOversight.app.utils.grab_officers({"name": "S", "dept": department}) | ||
| assert officer in results.all() |
There was a problem hiding this comment.
Idk how this test has been passing 🤔
| @@ -49,6 +49,7 @@ services: | |||
| environment: | |||
| ENVIRONMENT: development | |||
| FLASK_DEBUG: 1 | |||
| SQLALCHEMY_WARN_20: 1 | |||
There was a problem hiding this comment.
Turn on SQLAlchemy 2.x deprecation warnings
AetherUnbound
approved these changes
May 25, 2023
| @@ -49,6 +49,7 @@ services: | |||
| environment: | |||
| ENVIRONMENT: development | |||
| FLASK_DEBUG: 1 | |||
| SQLALCHEMY_WARN_20: 1 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Upgrade SQLAlchemy (finally)! Most changes are adapted from lucyparsons@14bfc5b
Notes for Deployment
None!
Screenshots (if appropriate)
N/A
Tests and linting
I have rebased my changes on
mainjust lintpassesjust testpasses