Upgrade WTForms and use WTForms-SQLAlchemy #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requirements.txt
Outdated
| @@ -20,4 +20,5 @@ python-dateutil==2.8.2 | |||
| python-dotenv==0.20.0 | |||
| SQLAlchemy==1.4.41 | |||
| us==2.0.2 | |||
| WTForms<3.0.0 | |||
| WTForms<4.0.0 | |||
There was a problem hiding this comment.
Did we want to maybe pin this rather than having it be ambiguous?
There was a problem hiding this comment.
I can do that! I just copied what dependabot suggested but that's probably a better idea
AetherUnbound
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #245 and replaces #251 .
wtforms.ext.sqlalchemywas removed in WTForms 3.0 so a couple changes were needed before we could upgradeNotes for Deployment
None!
Screenshots (if appropriate)
Tests and linting
I have rebased my changes on
mainjust lintpassesjust testpasses