Issue 241

[rsk2]

Description of Changes

Notes for Deployment

Screenshots (if appropriate)

Tests and linting

• I have rebased my changes on main

• just lint passes

• just test passes

[rsk2]

Hi @sea-kelp, I have changed app.env to app.debug. Is this fine?

[sea-kelp]

We actually want to use app.config["ENVIRONMENT"] instead of app.debug to check the value of the new variable you've added!

[rsk2]

Ok, makes sense

[sea-kelp]

Great work! There is just one other place where FLASK_ENV is used

OpenOversight/.env.example

Line 12 in 1de4c6b

FLASK_ENV=development # for prod: production

[sea-kelp]

We actually want to use app.config["ENVIRONMENT"] instead of app.debug to check the value of the new variable you've added!

[sea-kelp]

Hi @rsk2, looks like there's one more place where you need to make a change:

This section:

OpenOversight/OpenOversight/app/config.py

Lines 11 to 12 in 1de4c6b

	class BaseConfig(object):
	# DB SETUP

should be changed to:

class BaseConfig(object):
    ENVIRONMENT = os.environ.get("ENVIRONMENT", "")
    # DB SETUP

[sea-kelp]

So close! The tests are failing because these two lines should have app.config["ENV"] changed to app.config["ENVIRONMENT"]

OpenOversight/OpenOversight/app/commands.py

Line 534 in 1de4c6b

if current_app.config["ENV"] == "testing" or prompt_yes_no(

OpenOversight/OpenOversight/app/commands.py

Line 575 in 1de4c6b

if force_create and current_app.config["ENV"] == "production":

[rsk2]

@sea-kelp , I have made the changes in OpenOversight/OpenOversight/app/commands.py

Additionally, I ran just test on my local and test_commands passes. However, a different test has failed; please see the screenshot below:

[sea-kelp]

@sea-kelp , I have made the changes in OpenOversight/OpenOversight/app/commands.py

Additionally, I ran just test on my local and test_commands passes. However, a different test has failed; please see the screenshot below:

It looks like the test run passed on here so I think it might just be a transient Selenium error?

Really appreciate your help with fixing this issue! :)

[AetherUnbound]

Thank you for the contribution @rsk2!

[AetherUnbound]

I've updated our .env file in production so this won't cause any hiccups on our next release 🙂