-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newton grav 2d accuracy test #98
Conversation
Adjusted constructor of LandingModule, fixed some variable overlaps in NewtonGravity2d.
Changes to NewtonGravity2d seem to have made it realistic, still working on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go through all of this and clean it up. Dead code, bad commenting practices, etc. This won't go into main until production ready!
} | ||
} | ||
} | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this all commented out? Either it's good code, or it's got to go
//NASA drag formula | ||
double dragFormula = dScale*vSq; //follow the NASA given formula to get the mathematical force applied by drag | ||
//velo squared | ||
// double vSq = stateInfo.velocity.get(j).dotProduct(stateInfo.velocity.get(j)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful? not? sort out the comments
State2d nextState = (State2d) solver.step(grav, time, state, stepSize); | ||
if(DEBUG) | ||
{ | ||
// System.out.println("Start State" + state.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're going to use/not use the debug variable, then do that, don't disable with comments
while (time < numberOfSteps) { | ||
|
||
State2d nextState = (State2d) solver.step(grav, time, state, stepSize); | ||
// actual = nextState.position.get(0); //get(0) is a placeholder value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
|
||
Vector2d expected = new Vector2d(); | ||
|
||
// assertEquals(expected,actual,error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
No description provided.