Newton grav 2d accuracy test #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted constructor of LandingModule, fixed some variable overlaps in NewtonGravity2d.
Changes to NewtonGravity2d seem to have made it realistic, still working on it.
S010MON
requested changes
Jun 17, 2021
| } | ||
| } | ||
| } | ||
| // |
There was a problem hiding this comment.
Why is this all commented out? Either it's good code, or it's got to go
| //NASA drag formula | ||
| double dragFormula = dScale*vSq; //follow the NASA given formula to get the mathematical force applied by drag | ||
| //velo squared | ||
| // double vSq = stateInfo.velocity.get(j).dotProduct(stateInfo.velocity.get(j)); |
There was a problem hiding this comment.
Useful? not? sort out the comments
| State2d nextState = (State2d) solver.step(grav, time, state, stepSize); | ||
| if(DEBUG) | ||
| { | ||
| // System.out.println("Start State" + state.toString()); |
There was a problem hiding this comment.
If you're going to use/not use the debug variable, then do that, don't disable with comments
| while (time < numberOfSteps) { | ||
|
|
||
| State2d nextState = (State2d) solver.step(grav, time, state, stepSize); | ||
| // actual = nextState.position.get(0); //get(0) is a placeholder value |
|
|
||
| Vector2d expected = new Vector2d(); | ||
|
|
||
| // assertEquals(expected,actual,error); |
S010MON
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.