Potential fix for code scanning alert no. 1: Workflow does not contain permissions #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a security alert by adding explicit permissions to the Detekt workflow to follow the principle of least privilege for GitHub Actions.
- Adds a
permissionsblock to restrict workflow access to only required permissions - Grants
contents: readfor accessing repository files andsecurity-events: writefor uploading SARIF files
| # This workflow performs a static analysis of your Kotlin source code using Detekt. | ||
| # It scans on push, PR, scheduled cron, or manual trigger. | ||
|
|
||
| name: Scan with Detekt |
There was a problem hiding this comment.
The permissions block should be indented consistently with other top-level workflow keys. Based on the file structure, it appears this should be at the same indentation level as 'name' and 'on'.
Suggested change
| name: Scan with Detekt | |
| name: Scan with Detekt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/JahidHasanCO/diffly/security/code-scanning/1
To fix the issue, we will add a
permissionsblock to the workflow. Since the workflow primarily reads repository contents and uploads a SARIF file, it only requirescontents: readandsecurity-events: writepermissions. Thecontents: readpermission allows the workflow to access repository files, andsecurity-events: writeis necessary for uploading SARIF files to GitHub's security tab.The
permissionsblock will be added at the workflow level to apply to all jobs, ensuring consistency and reducing redundancy.Suggested fixes powered by Copilot Autofix. Review carefully before merging.