Add --retry and --retry-interval option to retry request until asserts and captures are ok

[jcamiel]

Add --retry and --retry-interval option to retry request until asserts and captures are ok.

Closes #525.

[Jiehong]

Maybe instead of retry being a boolean, a max_retries set to 0 by default would allow to both handle activating retrying, and setting a limit to the number of retries.

@jcamiel WDYT?

[jcamiel]

I don't know if it's better to have a a maximum retry count, a maximum retry duration, etc... For now I'm going to go with
--retry flag + --retry-max-count COUNT, --retry-max-duration SECONDS and --retry-interval MILLISECONDS(I like the options to have a common prefix like --report-html and report-unit)... But nothing is set in stone!

[Jiehong]

To me --retry-max-duration feels like is sort of in conflict with --retry-max-count and --retry-interval.

--retry-max-duration also feels a bit variable. If you service is slow, it might mean to retry a handle of times, but it might mean thousands of times instead.

My 2 usecases would be:

Unreliable endpoint:

1. this service is a bit flaky, retry it
2. wait 1 second before retrying, then 2, then 4, then 8 seconds (backing off);
3. don't retry more than 3 times, because it's quite unlikely

Second usecase is:

1. I'm polling this api, because a status is changing, and I want to wait until it happens
2. wait a constant time of 500ms between retries
3. stop after 10 retries, if condition not met.

I also like the --retry- prefix to group all those options, though!

[jcamiel]

@Jiehong Thanks for the usecase, I will take these into accounts once the PR is more advance (I need to do prior work on master to make it easier to develop)

[fabricereix]

/accept

[github-actions]

🕗 /accept is running, please wait for completion.

[github-actions]

✅ Pull request accepted and closed by fabricereix with fast forward merge..

# List of commits merged from Orange-OpenSource/hurl/feature/option-retry branch into Orange-OpenSource/hurl/master branch:

• 43e6f70 Add comment.
• 104360a Update integration tests.
• a58d4f2 Add --retry and --retry-interval options.