-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:focus-visible
polyfill
#393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoodd
added
v5
dependencies
Pull requests that update a dependency file
js
Pull requests that update Javascript code
feature
accessibility
labels
May 20, 2020
ffoodd
force-pushed
the
feature/focus-visible
branch
from
May 20, 2020 15:44
7a8cda1
to
99eb950
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
dependencies
Pull requests that update a dependency file
feature
js
Pull requests that update Javascript code
v5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
to contribute back: won't be merged :/focus-visible
polyfill and styles to match v4outline
globally2px
everywhere, with an offset to ensure spacing;box-shadow
alongsideoutline
to have two colors displayed: done forbutton
s, inspired by a comment in Bootstrap "Text and Non-text Contrast" issue — #29422v4-dev
)Anything else?
Questions
Should form inputs use transitionnedEdit: impossible, sinceoutline
s too? For now they're stuck withborder-color
; and FWIW,.form-check
s currently use both, which feels quite wrong…:focus-visible
specification understanding by browsers are thatinput
s should always showoutline
s. It won't sepearate:focus
and:focus-visible
, that's why they're still usingborder-color
only.