Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:focus-visible polyfill #393

Merged
merged 18 commits into from
May 27, 2020
Merged

:focus-visible polyfill #393

merged 18 commits into from
May 27, 2020

Conversation

ffoodd
Copy link
Contributor

@ffoodd ffoodd commented May 20, 2020

Fixes #139

  • PR on Bootstrap to contribute back: won't be merged :/
  • focus-visible polyfill and styles to match v4
    • apply outline globally
    • check and customize focus for each component
  • check for contrasts and improvements as suggested by @Aniort:
    1. size is 2px everywhere, with an offset to ensure spacing;
    2. contrasts should be good since we're using a single color scheme.
  • ensure visibility by using box-shadow alongside outline to have two colors displayed: done for buttons, inspired by a comment in Bootstrap "Text and Non-text Contrast" issue — #29422
  • document (mostly get docs back from v4-dev)

Anything else?

Questions

  • Should form inputs use transitionned outlines too? For now they're stuck with border-color; and FWIW, .form-checks currently use both, which feels quite wrong… Edit: impossible, since :focus-visible specification understanding by browsers are that inputs should always show outlines. It won't sepearate :focus and :focus-visible, that's why they're still using border-color only.

@ffoodd ffoodd added v5 dependencies Pull requests that update a dependency file js Pull requests that update Javascript code feature accessibility labels May 20, 2020
@ffoodd ffoodd added this to the 5.0.0-alpha milestone May 20, 2020
@ffoodd ffoodd self-assigned this May 20, 2020
@ffoodd ffoodd marked this pull request as ready for review May 27, 2020 08:13
@ffoodd ffoodd merged commit 7c47973 into v5-dev May 27, 2020
@ffoodd ffoodd deleted the feature/focus-visible branch May 27, 2020 08:21
@ffoodd ffoodd linked an issue May 27, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility dependencies Pull requests that update a dependency file feature js Pull requests that update Javascript code v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus visibility
1 participant