Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y audit: enlarge touch targets of right side menu "On this page" #2726

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Sep 10, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#2667 issue 1-8

Description

Increase vertical padding to make the clicking area at least 24px high

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f2e5f28
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66e42308602b280008bacf3c
😎 Deploy Preview https://deploy-preview-2726--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no more left-aligned with "On this page" correctly with these values (tablet and desktop breakpoints, mobile seems OK):

Screenshot 2024-09-11 at 08 35 58

Reference on the main branch:

Screenshot 2024-09-11 at 08 36 57

site/assets/scss/_toc.scss Outdated Show resolved Hide resolved
@julien-deramond julien-deramond merged commit 615fabb into main Sep 13, 2024
11 of 12 checks passed
@julien-deramond julien-deramond deleted the main-his-a11y-enlarge-right-menu-targets branch September 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants