Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix different links having same accessible name #2723

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Sep 9, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

This issue has been seen while reading OUDS Web documentation (PR #2713 )

Description

Change the labels of links to make them discriminating.

Motivation & Context

The links to Boosted and Booststrap license have the same accessible name ("in the project repository") but not the same target, which is an accessibility issue.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit bd8cd4c
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66fe3b38a7c97300088b55b6
😎 Deploy Preview https://deploy-preview-2723--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, just wondering if we should include full word inside the Boosted license. However, it already works like a charm.

@julien-deramond julien-deramond merged commit 65b4109 into main Oct 3, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-his-a11y-links-accessible-name branch October 3, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants