-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audit a11y: Change wrong images labels #2709
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question is still running for me, but the logo is mainly used in the header and often used as a part of the brand name. For instance I'm thinking about Orange Cyberdefense, Orange Foundation, etc... Which title would then say Orange master logo Cyberdefense
. My opinion is balancing between:
- We are a documentation so everything isn't perfect but we ease our UX.
- If people want to use the logo, they need to adapt the label and so we can have whatever in here.
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
We didn't talk about this: of course, in the context of a website, if the logo is in a links that leads to home page, as it often does, the label shouldn't be "XXX logo" but something like "XXX home". For this, I think that developers can be inspired by Boosted code itself, don't you think? In this example, we don't have any context, so it would be weird to use such a label... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
#2667
Description
Change labels:
Motivation & Context
Types of change
Live previews