Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(switch): Handle the invalid case for unchecked switch #2621

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jul 16, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #2619.

Description

Add a specific rule to handle this use case, since the invalid state on a switch shouldn't be valid HTML.
Results:
image

Motivation & Context

See #2619.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 59ffbe9
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66976216ed534b00082ed48b
😎 Deploy Preview https://deploy-preview-2621--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond self-requested a review July 17, 2024 06:18
@julien-deramond julien-deramond merged commit fdbb7d3 into main Jul 17, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-lmp-remove-filter-switch branch July 17, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Default switch checkbox input hasn't the same color when the 'is-invalid' class is used in it
2 participants