-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask user if they wish to delete Extensions permanently or not #919
Merged
OverloadedOrama
merged 18 commits into
Orama-Interactive:master
from
Variable-ind:exension-trash
Oct 29, 2023
Merged
Ask user if they wish to delete Extensions permanently or not #919
OverloadedOrama
merged 18 commits into
Orama-Interactive:master
from
Variable-ind:exension-trash
Oct 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Variable-ind
commented
Oct 9, 2023
•
edited
Loading
edited
- move the faulty extension to a separate folder
- don't delete incompatible extensions (v0.11.x --> v1.0). so that they can still be used with (0.11.x)
- on uninstall ask user if they wish extension to move to bin or permanent deletion
Variable-ind
changed the title
don't delete Extensions permanently
Don't delete Extensions permanently
Oct 11, 2023
Variable-ind
changed the title
Don't delete Extensions permanently
Ask user if they wish to delete Extensions permanently or not
Oct 27, 2023
(missed it due to a small blunder)
OverloadedOrama
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.