Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask user if they wish to delete Extensions permanently or not #919

Merged
merged 18 commits into from
Oct 29, 2023

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Oct 9, 2023

  • move the faulty extension to a separate folder
  • don't delete incompatible extensions (v0.11.x --> v1.0). so that they can still be used with (0.11.x)
  • on uninstall ask user if they wish extension to move to bin or permanent deletion

@Variable-ind Variable-ind changed the title don't delete Extensions permanently Don't delete Extensions permanently Oct 11, 2023
@Variable-ind Variable-ind changed the title Don't delete Extensions permanently Ask user if they wish to delete Extensions permanently or not Oct 27, 2023
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OverloadedOrama OverloadedOrama merged commit 1d35198 into Orama-Interactive:master Oct 29, 2023
4 checks passed
@Variable-ind Variable-ind deleted the exension-trash branch October 29, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants