Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idle fps setting #543

Merged

Conversation

Schweini07
Copy link
Contributor

A new setting was added trough which the user can set how many FPS Pixelorama should have when idle.
image
Additionally a bug was fixed where when the user has another application as their focus and reenters Pixelorama with the mouse but not focusing it and then exiting with the mouse, the target_fps would be set to the standard.

@Variable-ind
Copy link
Contributor

Hy, If the idle FPS is configurable then i think Limit FPS to 1 when app loses focus should also be changed to something like Limit FPS when app loses focus

@Variable-ind
Copy link
Contributor

Also i think the configuration dialog should be hidden by default and only appear when the checkbox is enabled (cause it's associated with the checkbox)

@Schweini07
Copy link
Contributor Author

Good catch, I forgot about that!
Regarding your suggestion to hide the setting, I think that should not be done, it hides useful information from the user and includes extra work that may not be worth it.

@Variable-ind
Copy link
Contributor

Variable-ind commented Sep 28, 2021

Yeah, but the field is only useful when the checkbox is checked, i don't think it serves a purpose if the checkbox is unchecked. i mean something like what i did with live preview checkbox in HSV dialogue (But reversed...).

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

(In case someone was not present in our discussion in Discord, we decided to disable the "Set idle FPS" setting when Limit FPS is off, instead of hiding it)

@OverloadedOrama OverloadedOrama merged commit 502c7d9 into Orama-Interactive:master Sep 29, 2021
@Schweini07 Schweini07 deleted the idle-cpu-setting branch September 29, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants