Improved the tiling feature #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OverloadedOrama
requested changes
Nov 13, 2020
There was a problem hiding this comment.
Overall it looks good, but there is a bug when selecting a cel on the timeline, while one of the tile modes is active. The transparent background gets resized and it only fills the first square. To fix it, we could add this piece of code in TransparentChecker's _ready() method, under the if statement.
match Global.tile_mode:
Global.Tile_Mode.NONE:
set_size(Global.current_project.size)
set_position(Vector2.ZERO)
Global.Tile_Mode.BOTH:
set_size(Global.current_project.size*3)
set_position(-Global.current_project.size)
Global.Tile_Mode.XAXIS:
set_size(Vector2(Global.current_project.size.x*3, Global.current_project.size.y*1))
set_position(Vector2(-Global.current_project.size.x, 0))
Global.Tile_Mode.YAXIS:
set_size(Vector2(Global.current_project.size.x*1, Global.current_project.size.y*3))
set_position(Vector2(0, -Global.current_project.size.x))
This basically checks the tile mode option and resizes the checker accordingly. There are also issues with the grid, especially with the isometric grid, but I will look into that later.
|
ready for another review |
src/UI/TransparentChecker.gd
Outdated
| @@ -36,7 +36,7 @@ func _init_position(id : int): | |||
| 2: | |||
| Global.tile_mode = Global.Tile_Mode.XAXIS | |||
| Global.transparent_checker.set_size(Vector2(Global.current_project.size.x*3, Global.current_project.size.y*1)) | |||
| Global.transparent_checker.set_position(Vector2(-Global.current_project.size.x, 0)) | |||
| Global.transparent_checker.set_position(Vector2(-Global.current_project.size.y, 0)) | |||
There was a problem hiding this comment.
This line was fine as it was, my comment was about YAXIS, line 43.
OverloadedOrama
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added more tiling options like tile in x axis, y axis and both axis together.