-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mac export workflow #319
Merged
OverloadedOrama
merged 11 commits into
Orama-Interactive:master
from
huskeee:mac-export
Aug 26, 2020
Merged
Update Mac export workflow #319
OverloadedOrama
merged 11 commits into
Orama-Interactive:master
from
huskeee:mac-export
Aug 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to implement Mac exporting on GitHub Actions
First try of implementing working Mac exports. Messy but hope it works.
Changed the export templates archive's name to see if it fixes anything
Set env variables for version and export name, for some reason the ones set in the workflow didn't seem to work
Hardcoded the GODOT_VERSION and EXPORT_NAME variables.
Fixed typo in export templates link
Fixed another typo in the build section.
Try to fix "./Godot: permission denied" error
Fixed "No such file or folder" error when making app executable
Fixed yet another typo
Finally passes all checks! |
OverloadedOrama
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to create working macOS exports.