Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the line2d to plot line pixel when drawing line. #260

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Change the line2d to plot line pixel when drawing line. #260

merged 1 commit into from
Jun 10, 2020

Conversation

Kinwailo
Copy link
Contributor

Using line2d, we dunno where the actual pixel is drawn. I changed it to plot the line like the circle brush.

OverloadedOrama
OverloadedOrama approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The only thing I was worried about is the performance. I tested it on large images and while there is some delay, it's not bad. On small images it runs perfectly of course. Thank you!

@OverloadedOrama OverloadedOrama merged commit 860173d into Orama-Interactive:master Jun 10, 2020
@Kinwailo Kinwailo deleted the dev branch June 10, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kinwailo @OverloadedOrama