Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isometric grid calculations using ints instead of floats #1069

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix isometric grid calculations using ints instead of floats #1069

merged 1 commit into from
Aug 9, 2024
+14 −12

Conversation

kleonc
Copy link
Contributor

@kleonc kleonc commented Aug 9, 2024

Fixes a regression from #900 which changed some floating point calculations into integers.

Example broken setup Before
(v1.0.1-stable)		 After
(this PR)
L7FHB09F6s Pixelorama_X81ZjEYRnx Godot_v4 2 2-stable_win64_aPS7RxGvq3

@kleonc kleonc force-pushed the isometric_grid_integer_calculations_fix branch from 2cd8a12 to ba0818f Compare August 9, 2024 10:58
OverloadedOrama
OverloadedOrama approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@OverloadedOrama OverloadedOrama merged commit 92d7bbf into Orama-Interactive:master Aug 9, 2024
4 checks passed
@kleonc kleonc deleted the isometric_grid_integer_calculations_fix branch August 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleonc @OverloadedOrama