Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shading tool Hue Shifting should allow for negative values #1015

Closed
Srekel opened this issue May 4, 2024 · 2 comments
Closed

Shading tool Hue Shifting should allow for negative values #1015

Srekel opened this issue May 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Srekel
Copy link

Srekel commented May 4, 2024

Pixelorama version:
0.11.4-stable

OS/device including version:
Windows 11

Issue description:
With the shading tool, the Hue and Value numbers change as expected when using Lighten and Darken, in that they both add and subtract. Saturation only adds however, even in Darken mode. I think that's a straight up bug.

However, for Hue, it would definitely make sense to be able to specify a negative value. In my case I have some grass, and where it's in shadow beneath trees, I'd like it to be darker ✅, I'd like the saturation to go down 🐞 , and, I'd also like it to be tinted a bit towards brown, i.e. go "up" on the hue scale.

So I think a more comprehensive solution would "simply" be to make the sliders go in the positive and negative.

(If you do this you wouldn't really need to keep lighten and darken as separate options, but honestly it's still quite useful to be able to just flip that and keep painting, rather than change the Value slider from say -10 to 10. )

@Srekel Srekel added the bug Something isn't working label May 4, 2024
@OverloadedOrama
Copy link
Member

In hue shifting mode, saturation is supposed to decrease when brightening and increase when darkening, as explained here https://www.oramainteractive.com/Pixelorama-Docs/user_manual/shading#hue-shifting

Sliders going negative sounds good to me, I implemented it in d734ae2 and it will be available for version 1.0. Thank you for the suggestion!

@Srekel
Copy link
Author

Srekel commented May 4, 2024

Cool, impressive how fast you fixed it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants