-
Notifications
You must be signed in to change notification settings - Fork 10
(EPROC-22810) PROC Administration - System Information Processes endpoint refinement #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
(EPROC-22810) PROC Administration - System Information Processes endpoint refinement #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refines the Process Administration UI interactions by switching several node/variable/assignee operations to AJAX-style fetch calls and changing corresponding controller actions to return JSON success responses.
Changes:
- Added a shared UI error container and a new i18n message for generic server communication failures.
- Refactored variable/node ordering and delete operations to use
fetch+ JSON responses (and introduced common delete handling in the nodes list). - Updated multiple controller actions to enforce HTTP methods and return JSON
{success: ...}payloads instead of redirects.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| grails-app/views/processNodeDef/nodeForm.gsp | Adds an error container intended for AJAX error display. |
| grails-app/views/processDef/editProcess.gsp | Adds an error container intended for AJAX error display. |
| grails-app/views/processDef/_variablesList.gsp | Moves variable reorder/delete to fetch and updates DOM identifiers/classes. |
| grails-app/views/processDef/_nodesList.gsp | Moves node reorder/delete + transition delete to fetch and adds shared delete helper. |
| grails-app/views/common/_assigneesEditor.gsp | Migrates assignee add/delete to fetch and centralizes request handling. |
| grails-app/i18n/common.properties | Adds plugin.grailsflow.internalError message. |
| grails-app/controllers/ProcessVarDefController.groovy | Adds allowedMethods + JSON responses for delete/reorder endpoints. |
| grails-app/controllers/ProcessTransitionDefController.groovy | Adds allowedMethods + JSON response endpoint for transition delete (renamed action). |
| grails-app/controllers/ProcessNodeDefController.groovy | Adds allowedMethods + JSON responses for delete/reorder/assignee delete endpoints. |
| application.properties | Bumps snapshot version with ticket suffix. |
| GrailsflowGrailsPlugin.groovy | Aligns plugin version with ticket-suffixed snapshot. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6cbbb54
WojciechStrzelinski-oc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use such deep if statements
97e73db to
7e6183a
Compare
…ndpoint-refinement' [ci skip]
7e6183a to
8a74113
Compare
https://opuscapita.atlassian.net/browse/EPROC-22810