Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format code to pass new format checks #34

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Format code to pass new format checks #34

merged 8 commits into from
Apr 4, 2024

Conversation

NielsJPeschel
Copy link
Contributor

Proposed changes

Adds Pretty as dev dependency as well as a format check to ensure code adheres to a standard

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

.prettierignore Outdated
@@ -0,0 +1,49 @@
#VS Code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we need this file? When we run prettier we are pointing to .gitignore, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Done

@nthurow
Copy link
Contributor

nthurow commented Apr 4, 2024

This feels so much better 😄

@NielsJPeschel
Copy link
Contributor Author

This feels so much better 😄

Right?? Lint is up next

@NielsJPeschel NielsJPeschel merged commit 12180f8 into main Apr 4, 2024
5 checks passed
@NielsJPeschel NielsJPeschel deleted the prettier branch April 4, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants