Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality checks and dummy publish workflow #17

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Conversation

nthurow
Copy link
Contributor

@nthurow nthurow commented Feb 9, 2024

Proposed changes

Add two new workflows: one for checking the TypeScript build and unit tests and every PR, and a dummy job for publishing the package.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@nthurow nthurow merged commit 5b7c4f4 into main Feb 9, 2024
4 checks passed
@nthurow nthurow deleted the add_quality_checks branch February 9, 2024 20:24
@nthurow nthurow restored the add_quality_checks branch February 9, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants