Skip to content

Execute smaller subset of benchmarks on PR #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Execute smaller subset of benchmarks on PR #233

merged 4 commits into from
Jan 8, 2025

Conversation

OptimumCode
Copy link
Owner

Resolves #227

@OptimumCode OptimumCode added the repository enhancement Changes to make the repository look better label Jan 8, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'KMP JSON schema validator'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 1597722 Previous: 9481407 Ratio
macosX64.CommonAvgTimeBench.validateBasic ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 5960.98156244898 us/op 2863.359403458214 us/op 2.08
macosX64.CommonAvgTimeBench.validateBasic ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 6982.695460294117 us/op 2945.2695735384614 us/op 2.37
macosX64.CommonAvgTimeBench.validateDetailed ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 13895.143034285715 us/op 6137.382462195123 us/op 2.26
macosX64.CommonAvgTimeBench.validateDetailed ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 14749.05528219178 us/op 6564.317594701986 us/op 2.25
macosX64.CommonAvgTimeBench.validateFlag ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 4398.724057077625 us/op 2096.1968796680494 us/op 2.10
macosX64.CommonAvgTimeBench.validateFlag ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 3.225895828235312 us/op 1.5657862056729583 us/op 2.06
macosX64.CommonAvgTimeBench.validateVerbose ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 28572.66140967742 us/op 11234.260193258424 us/op 2.54
macosX64.CommonAvgTimeBench.validateVerbose ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 25256.107916 us/op 11014.56541777778 us/op 2.29
macosX64.CommonAvgTimeBench.validate ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 6979.55944195122 us/op 2757.369600546448 us/op 2.53
macosX64.CommonAvgTimeBench.validate ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) 5234.083236966825 us/op 3165.890876203966 us/op 1.65

This comment was automatically generated by workflow using github-action-benchmark.

CC: @OptimumCode

@OptimumCode
Copy link
Owner Author

Execution time

Before: ~25 min
After: ~15 min

@OptimumCode OptimumCode merged commit 2f756ab into main Jan 8, 2025
19 checks passed
@OptimumCode OptimumCode deleted the support/227 branch January 8, 2025 17:09
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (9481407) to head (1597722).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files         133      133           
  Lines        3983     3983           
  Branches     1059     1059           
=======================================
  Hits         3606     3606           
  Misses         82       82           
  Partials      295      295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository enhancement Changes to make the repository look better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support: improve benchmark speed for PR validations
1 participant