June #1 Minor bug fixes #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OptimeeringBigya
force-pushed
the
release-june-2
branch
2 times, most recently
from
4ac2ae7 to
7bf199b
Compare
Handle edge case where number of items to be returned is a multiple of limit causing last response from API to have no items; but collapsing response together directly accesses the 1st item causing index error. Descriptions were not being added if the parameter was not required.
OptimeeringBigya
force-pushed
the
release-june-2
branch
from
7bf199b to
41510a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle edge case where number of items to be returned is a multiple of limit causing last response from API to have no items; but collapsing response together directly accesses the 1st item causing index error.
Descriptions were not being added if the parameter was not required.