Skip to content

Conversation

@HALIS-sh
Copy link
Contributor

截屏2024-07-22 08 37 44

Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contrib/tool-finetune/README.md

  • [Style] line 3: It is not conda environment, it is pip dependency. Users can use other environment management tools such as virtualenv, so no need to restrict to conda.
  • [Question] line 23: I am wondering if this field a string of list, or already revised to a list of strings?
  • [Style] line 73-75: add prefixed --.

contrib/tool-finetune/function_call_finetune.py

  • [Style] line 3: Record in roadmap: remember to remove this line when integrated into src/lmflow. Can coordinate with @wheresmyhair when modifying the roadmap and add one line under the task of "tool integration".
  • [Architecture] line 138-155: the fingerprint logics can be reused by encapsulating in a separate function. Can be done in the next round of refactoring.

src/lmflow/utils/conversation_template/llama.py

  • [Architecture] Record in roadmap: the tool support can be merged with the original template when refactoring.

src/lmflow/utils/conversation_template/qwen.py

  • [Architecture] Record in roadmap: the tool support can be merged with the original template when refactoring.

@research4pan research4pan merged commit c323f44 into OptimalScale:main Aug 12, 2024
@HALIS-sh
Copy link
Contributor Author

contrib/tool-finetune/README.md

  • [Response] line 23: Thank you for asking that question. This field has been revised to a list of strings.

@wheresmyhair wheresmyhair mentioned this pull request Sep 25, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants