Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability update #857

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Usability update #857

merged 6 commits into from
Jun 14, 2024

Conversation

wheresmyhair
Copy link
Collaborator

  1. RM shell shebang fix
  2. Add padding side option, by default right (as what LMFlow did previously), when set to auto, will follow the tokenizer default padding_side
  3. Specify num_labels=1 for HFTextRegressionModel to avoid some rare bugs
  4. HFTextRegressionModel supports text_only and text2text data (only for inference, since training a reward model needs preference(paired) data)

research4pan
research4pan approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wheresmyhair wheresmyhair merged commit d7055e3 into main Jun 14, 2024
2 checks passed
@wheresmyhair wheresmyhair deleted the yizhenjia-maintenance branch June 17, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@research4pan research4pan research4pan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wheresmyhair @research4pan