Skip to content

added --skip-send-invite flag to "create user" cmd#333

Merged
davidbloss merged 5 commits intomainfrom
db/support-skip-send-user-invite
Sep 30, 2024
Merged

added --skip-send-invite flag to "create user" cmd#333
davidbloss merged 5 commits intomainfrom
db/support-skip-send-user-invite

Conversation

@davidbloss
Copy link
Contributor

Resolves #463

Problem

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change

src/cmd/user.go Outdated
opslevel create user "jane@example.com" "Jane Doe" Admin --skip-send-invite --skip-welcome-email
`,
Args: cobra.MinimumNArgs(2),
Args: cobra.RangeArgs(2, 4),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be RangeArgs(2, 3). The new flag is not a arg only email, name and role are the arguments - the rest are flags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 you are spot on. Adding this in

@davidbloss davidbloss merged commit 4090eb5 into main Sep 30, 2024
@davidbloss davidbloss deleted the db/support-skip-send-user-invite branch September 30, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants