Fix future deprecation

[OpherV]

[fabmars]

Yeah that was expected: public **abstract** class TaskDialogPanelProvider declares

@SuppressWarnings("DeprecatedIsStillUsed")
 @Deprecated
 @Nullable
 public abstract TaskDialogPanel getOpenTaskPanel(@NotNull Project project, @NotNull Task task);

Since GitflowTaskDialogPanelProvider extends TaskDialogPanelProvider, there is no other choice but to implement the method

Funny to see that idea's own VcsTaskDialogPanelProvider was also compelled to provide with a dummy override for that method. They have the same warning on their builds.

One way to solve is is to GitflowTaskDialogPanelProvider extends VcsTaskDialogPanelProvider LOL!

[enderteszla]

@fabmars @OpherV , this method in their implementation always returns null.
And, yes, I guess the most proper solution is to GitflowTaskDialogPanelProvider extends VcsTaskDialogPanelProvider.
Because, once they eliminate TaskDialogPanelProvider.getOpenTaskPanel(@NotNull Project, @NotNull Task), VcsTaskDialogPanelProvider.getOpenTaskPanel(@NotNull Project, @NotNull Task) immediately goes away as well.

[enderteszla]

@fabmars , will you submit PR?
Or should I? I would do that if you don't.

[OpherV]

@enderteszla Looks like @fabmars didn't get around to it so if you do a PR that would be appreciated! :)

[enderteszla]

@OpherV , okay, which branch should I make PR into?

[enderteszla]

develop?

[enderteszla]

@OpherV , there are two solutions, one is a plain one and another is a bit more advanced one.

[enderteszla]

By the way (since I do not know how to ask you in any other way),
Why do they at JetBrains call gitflow4idea again not supported?
What issue should we handle to make them call it supported once again?

[OpherV]

yep develop is the one. It would be unbecoming for a git flow plugin to not use git flow 😀
It's not that it's not supported, it's that they're deprecating methods from time to time and so I have to make sure to work around those so that once the APIs are actually removed from an Idea version the plugin is still usable.

Currently the only issue is the one at the top of this thread.

Thanks so much for the PRs! I'll review soon

[fabmars]

@enderteszla sorry I'm into some turmoil at the moment (and I have another pretty complex PR in progress on a JBoss project), I can't dive into this right now.

Just to make it clear with my earlier comment about this deprecation, there was no real way to avoid this warning because GitflowTaskDialogPanelProvider extends TaskDialogPanelProvider, an internal Jetbrains class which is itself bound to this deprecation.

If I remember correctly GitflowTaskDialogPanelProvider extends VcsTaskDialogPanelProvider is like putting a plaster on a peg leg cause VcsTaskDialogPanelProvider extends TaskDialogPanelProvider itself! It's just hiding the problem. Solving it in not in our powers.

Therefore, my approach was a "wait & see" one where I would have advised to wait for Jetbrains to update their own classes before the getOpenTaskPanel() method is officially forbidden to use. Clearly TaskDialogPanelProvider triggers the same warning as we have, they will have to change it (else it's a case of "do as I say don't do what I do" :) )

[fabmars]

For the sake of double checking I put the latest version of the IJ gradle plugin in the project id 'org.jetbrains.intellij' version '0.4.21'

As of today IJ 2020.1.2 uses api 201.6668.121, so TaskDialogPanelProvider is unchanged.

[enderteszla]

@fabmars , we cannot wait. @OpherV says, this is why the plugin is deprecated.
I cannot update to new versions of IDEA because there'll be no gitflow4idea there.