-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/implement flask admin #403
base: main
Are you sure you want to change the base?
Feature/implement flask admin #403
Conversation
@aaron-suarez this PR contains the admin routes and the access control but some UI related things like - login page UI, logout page routing is remaining. |
@fumblehool Thanks so much for your contribution! I haven't pulled it down to run it just yet, but I'd like to give it a really thorough review because it changes the models. I think that this is also going to require a migration file to update the database, right? Can we get that added and the conflicts resolved and then I'll give it a really good review? Thanks! |
@aaron-suarez I've pushed the migrations + fixed the lint issues. |
@aaron-suarez have you tried it locally? |
So locally, I got it running in the flask shell, but I'm a bit unclear as to the interface for creating a new user and assigning roles. Would you mind commenting with an example of how to add an admin user so I can do that locally and ensure that everything works as expected? I'm sure it's in the Thanks again for this contribution, it's looking good so far, just gotta go through the flow to make sure everything works 😄 |
Also, please rebase to resolve conflicts |
I ran it and navigated to
Let me know when you're ready for another review (because I assume you're still trying to work this out). If you need help, feel free to hit me up on slack. |
…into feature/implement-flask-admin
@aaron-suarez I've fixed the issues -
|
In order for the tests to pass, we'll probably need a default |
Other than that, it looks like it works at a first pass. I'll do some more extensive testing later, but I really appreciate the effort here! |
@aaron-suarez I've added default values for |
@aaron-suarez I've resolved the comment. Please review, Thanks 😄 |
fixes #134