This repository was archived by the owner on Dec 3, 2019. It is now read-only.
add user and password values to prod #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemh
reviewed
Nov 10, 2018
| @@ -35,4 +35,6 @@ test: | |||
| production: | |||
| <<: *default | |||
| host: <%= ENV['POSTGRES_HOST'].present? ? ENV['POSTGRES_HOST'] : 'operationcode-psql-postgresql' %> | |||
| user: <%= ENV['POSTGRES_USER'] %> | |||
There was a problem hiding this comment.
I believe <<: *default is like a spread operator.
I think you can leave these out and only define database
There was a problem hiding this comment.
Yeah I was still getting missing env var issues. But that was because the redis pod isn't updating when this deploys. I updated the pod and it worked. Going to revert this change, and see if it breaks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue Resolved
Fixes #