Bump openlifu version and fix solution analysis display bug #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrahimebrahim
force-pushed
the
bump-openlifu
branch
from
7d186cf to
d90868e
Compare
Merged
1 task
arhowe00
approved these changes
Apr 10, 2025
Contributor
arhowe00
left a comment
arhowe00
left a comment
There was a problem hiding this comment.
Checked out and tested the version end to end. Looks good.
| # except now it's actually a string like "Annotated[...]" with a bunch of stuff in it | ||
| origin_is_list = "list[" in field.type | ||
| origin_is_union = "|" in field.type | ||
| type_args_involve_float = "float" in field.type |
Contributor
There was a problem hiding this comment.
Interesting solution, seems delicate but necessary. I like your very straightforward naming.
Contributor
Author
There was a problem hiding this comment.
Yes it's quite brittle but I figured since the whole approach will be replaced after we merge OpenwaterHealth/OpenLIFU-python#250 and start using that in #98, it's okay to have a crappy solution here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_hintsis unimportant -- it was towards a path I followed that ultimately failed, but I figured I'd keep that change because it will come in handy later