Add photocollection concept to database (#234) #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhowe00
force-pushed
the
234-add-openlifu-PhotoCollection-concept-to-database
branch
2 times, most recently
from
b6cf1bd to
2a46ba3
Compare
Collaborator
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
- Also initialize the empty folders when a new session is created, right? Is that needed?
- I think we should add the photocollection reference number as an attribute to Photoscan, so that there is a record of which photoscan came from which photocollection. But that would complicate this PR, requiring DVC data updates as well. So maybe a separate issue to be done later?
Contributor
Author
Yes, that is what happens in
I agree, I think in the end it will be helpful to also tag the photoscans, but right now we can treat them as independent and do that integration later. I'll open up an issue regarding that. |
ebrahimebrahim
approved these changes
Mar 6, 2025
Collaborator
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Looks good then, and thanks for opening that issue!
Please feel free to merge when happy with it
arhowe00
force-pushed
the
234-add-openlifu-PhotoCollection-concept-to-database
branch
from
2a46ba3 to
1b4c68e
Compare
Adds a concept of photocollections to the database. Photocollections are associated with the specific session_id of a specific subject_id, and they are identified by the reference_number. 'reference_number' was used instead of photocollection_id for consistency with 3D Open Water. 3D Open Water takes a collection of `.jpeg` photos and the goal of photocollections are to store that collection of photos into the database for downstream processing; specifically, the plan is for a photocollection of 70-80 photos of a patient's face to be used to create a mesh (i.e. a "photoscan" object). There is no special object associated with a photocollection -- it's just a collection of photos stored in a directory and identified by the reference_number. - Updates the database to valid state. The updated database includes two example photocollections for example_subject
arhowe00
force-pushed
the
234-add-openlifu-PhotoCollection-concept-to-database
branch
from
1b4c68e to
55bd6b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234
This is necessary for downstream work of generating a photoscan/mesh from the 70-80 photos from 3D Open Water. The 3D Open Water app does not generate a mesh, it just takes photos. So we store the photos for downstream analysis.
In detail
Adds a concept of photocollections to the database. Photocollections are associated with the specific session_id of a specific subject_id, and they are identified by the reference_number. 'reference_number' was used instead of photocollection_id for consistency with 3D Open Water. 3D Open Water takes a collection of
.jpegphotos and the goal of photocollections are to store that collection of photos into the database for downstream processing; specifically, the plan is for a photocollection of 70-80 photos of a patient's head to be used to create a mesh via an algorithm (i.e. a "photoscan" object). There is no special object associated with a photocollection -- it's just a collection of photos stored in a directory and identified by the reference_number.For review
This code is not unit tested but is pretty independent within the subject/session tree. Errors will likely be caught in its usage. Other than reading the code, you could pipe it through an LLM and see if you rolled the right RNG for it to discover a bug.